PROJECT: Altered source files

[Lui2]

Military Support

04.07.2004
ctp2_code/gs/gameobj/Player.cpp

Fixes missing recalculation of military support cost after changing the government type.

After changing the government, the military support costs were not recalculated. The only point where they were recalculated, was in the unitmanager advisor, when changing the percentual display of the military support costs to a absolute value.

This bug has a big influence of the production and therefore also a big influence of the whole game and can easily be used for abusing.

[Lui2]

City Investigation

04.07.2004
ctp2_code\gs\gameobj\UnitData.cpp

ctp2_data\default\gamedata\unit.txt
ctp2_data\default\gamedata\script.slc

ctp2_data\german\gamedata\info_str.txt
ctp2_data\english\gamedata\info_str.txt


Added two new messages to distinct message text after investigating a city depending if the unit was caught or not. I didn't like that the message was telling me that my spy was caught, but he wasn't.
Two strings are added to the info_str.txt and a call added to script.slc files.
INVESTIGATE_CITY_FAILED_ESC_VICTIM
INVESTIGATE_CITY_FAILED_ESC_AGRESSOR

Also changed the EliteChance in Units.txt to an absolute value, like it's used in the program.
Look here for exact background.

Also did one additional minor fix to the units.txt by changing the size of the UNIT_TANK from small to medium.

I add information about the new strings to the TranslationCenter thread.

[Lui2]

City Investigation
ZIP file

[Martin Gühmann]

Lui2 I would prefer it you would also provide the text files for the other languages if you don't have a translation you could at least fill the gaps with English text.

-Martin

[drulius]

originally posted by Lui2:
Also did one additional minor fix to the units.txt by changing the size of the UNIT_TANK from small to medium.

Does this mean Tanks won't go in helicopters anymore?

[Martin Gühmann]

Originally posted by drulius
Does this mean Tanks won't go in helicopters anymore?

Yes, it does mean. That's a fix all major mods do and therefore it is not wrong to include it here.

-Martin

[Lui2]

Sorting in NationalManager window

06.07.2004
ctp2_code/gs/gameobj/CityData.cpp
Fixed sometimes not correct filled m_shields_this_turn variable, that leads to wrong sorting sequence for number of "turns until production is finished" in NationalManager status window (maybe also to other wrong behaviours).

ctp2_code/ui/aui_ctp2/ctp2_listbox.cpp
Optimized sorting logic of list entries (only the half number of iterations (+ numer of entries) than before).

ctp2_code/ui/interface/NationalManagementDialog.cpp
Fixed sorting sequence for governor type in status tab for blank entries.

[Flinx]

Re: Sorting in NationalManager window

Originally posted by Lui2
06.07.2004
ctp2_code/gs/gameobj/CityData.cpp
Fixed sometimes not correct filled m_shields_this_turn variable, that leads to wrong sorting sequence for number of "turns until production is finished" in NationalManager status window (maybe also to other wrong behaviours).

[Fromafar]

Some crash prevention changes for missing strings and pictures:

gs\database\StrDB.cpp
ui\aui_common\aui_imagelist.cpp
ui\aui_common\aui_resource.h
ui\aui_common\textbase.cpp

Note: this does not prevent the pop-up (every time) when you try to access a missing file.

[Edit: link removed. Included in the 2004.08.01 source collection.]

[Fromafar]

Text file repairs for the Alexander scenario:
- added Corinthian League defeat message (as suggested by Immortal Wombat)
- repaired Babylon coronation event typo (as suggested by Immortal Wombat)
- repaired an invalid assignment in the Sidon event

AG_msg.slc
scenario.slc

[Edit: link removed. Included in the 2004.08.01 source collection.]

[kaan]

Activision patch reimplementation.
Bug #12 "Prevented cities from revolting twice in a row".

I have exposed to const.txt the amount of turns minimum between revolts.



.\ctp2_code\gs\database\ConstDB.cpp
.\ctp2_code\gs\database\ConstDB.h
.\ctp2_code\gs\gameobj\CityData.cpp
.\ctp2_code\gs\gameobj\CityData.h
.\ctp2_code\gs\gameobj\Player.cpp
.\ctp2_data\default\gamedata\Const.txt
.\Scenarios\AlexanderTheGreat\scen0000\default\gam edata\Const.txt

[kaan]

Activision patch reimplementation.
Bug #4 "Increased animation queue to 12, making unit-in-wrong-place bug less likely".


.\ctp2_code\gfx\spritesys\Actor.h

[Fromafar]

Did you see any differences after changing this? When testing this in the past, I got the impression that it didn't really help.

[kaan]

Well im not able to register any change as i didnt run into this bug in my playtesting and i dont know how to provoke it.

As this is the only animation queue i can find in the source im pretty sure that it is the right one.
It is used by every detail in the game that is animated as far as i can tell.

So the question remains if it is usefull but im sure that i have reimplemented the mentioned "fix" from activsion.

[Martin Gühmann]

According to the bug description they did not really fixed the bug, it sounds like they did something in the hope that it might make the problem less annoying. That's like shooting into the dark in the hope to hit the mark.