PROJECT: Altered source files

[Fromafar]

The reason is that the 'offending' piece of code is part of the compiler, and not of the Activision code.

Because of that, this warning does not really apply to us. It merely states (roughly translated from German) that the compiler has generated some symbols that contain more than 255 characters, and that for debugging purposes it has truncated these symbols to 255 characters.

As this is a piece of code that we are not going to modify at all, debugging it is not very interesting. And even with 'only' 255 characters, you probably would be able to find the correct symbol.

[J Bytheway]

Originally posted by Fromafar
The reason is that the 'offending' piece of code is part of the compiler, and not of the Activision code.

Ah yes. I didn't notice that. Silly me.

[Flinx]

Keep up the good work guys!

Did anyone look at the TEST/DEBUG: Slic built-in data accessors files? If these work maybe we could get a new playtest

[J Bytheway]

I was seriously considering releasing a new "official" playtest version incorporating them - I think that's the only way we'll get them tested...

[The Big Mc]

Go for it I am always reedy to play test.

[drulius]

code:--------------------------------------------------------------------------------#pragma warning(disable: 4786)--------------------------------------------------------------------------------

warning 4786 is very common when using STL containers, especially maps and sets. As FROMAFAR stated it is a truncation warning that can be safely ignored. Every time a container copies itself internally during code generation, it generates a unique name by concatenation and quickly surpasses the 255 char limit. At least this is the explanation I was given when we began studying STL containers this semester.

In Project->Settings [c/c++ tab, general category] you can set the warning level to NONE but it normally only reduces the number of warnings issued from hundreds to dozens.

Or you can use the #pragma in affected files, but note that

From MSDN VC++6 documentation:
For warning numbers greater than 4699, those associated with code generation, the warning pragma has effect only when placed outside function definitions. The pragma is ignored if it specifies a number greater than 4699 and is used inside a function. The following example illustrates the correct placement of warning pragmas to disable, and then restore, the generation of a code-generation warning message:
int a;
#pragma warning( disable : 4705 )
void func()
{
a;
}
#pragma warning( default : 4705 )

[Flinx]

The Great Library entry for Hospital is incorrect as I posted over in CTP2 Mods. The section of Great_Library.txt should read:

[IMPROVE_HOSPITAL_STATISTICS]
Gives:
Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by {BuildingDB(Building[0]).RaiseOvercrowdingLevel}
[END]

It should be the same as the entry for Incubation Center which follows it.

[Fromafar]

Activision patch reimplementation:

gs\gameobj\GameSettings.cpp
Use the difficulty and barbarian risk level as selected by the user when starting a new (scenario) game.

[Edit: link removed. Included in the 2004.06.05 source collection.]

[J Bytheway]

Originally posted by Flinx
The Great Library entry for Hospital is incorrect

I'm not sure what our approach towards errors in the text is at the moment. Probably its best to post about them in the translation centre, because they might be present in other languages too...

[J Bytheway]

I get the error:

F:\Games\CTP2Src2\ctp2_code\gs\world\Cell.cpp(962) : error C2660: 'GetFreight' : function does not take 1 parameters

with the above changes (2004.05.09.trade.zip). I'm going to have a look and see if I can figure out the problem...

[Fromafar]

This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input.

Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

[Martin Gühmann]

Originally posted by Flinx
The Great Library entry for Hospital is incorrect as I posted over in CTP2 Mods. The section of Great_Library.txt should read:

[IMPROVE_HOSPITAL_STATISTICS]
Gives:
Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by {BuildingDB(Building[0]).RaiseOvercrowdingLevel}
[END]

It should be the same as the entry for Incubation Center which follows it.

Well and what does it say originally.

Originally posted by Fromafar
This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input.

Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

Another problem with this database generator is that it does not regenerate all the files if it is necessary for instance I modified the RecordDescription.cpp that should have as consequence that all the generated files have to be regenerated, but at university a lot of files were not regenerated and it home same modification two files a header file and the according implemention file were not regenerated.

-Martin

[J Bytheway]

Originally posted by Fromafar
This error may occur when the TerrainImprovementRecord.h and .cpp files have not been updated from the terrimprove.cdb input.

Did you do a debug build first? IIRC some of the custom build steps are not executed properly in the other builds.

That would explain it. Thanks. I'll try a debug build now.

[J Bytheway]

Yep, that worked. Thanks again.

[Flinx]

Originally posted by Martin Gühmann
Well and what does it say originally.

In the English version:

[IMPROVE_HOSPITAL_STATISTICS]
Gives:
[color=red]Increases City Max Size[/color]
Reduces <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>Overcrowding<e> Effect by [color=red]{BuildingDB(Building[0]).RaiseMaxPopulation}[/color]
[END]

Which displays in game as

Gives:
Increases City Max Size
Reduces [color=blue][u]Overcrowding[/u][/color] Effect by 0

Going through the 2004.04.30 .RAR, the great library is not included for French, Italian or Japanese; the German version is ok as it includes both overcrowding and maxpop; the Spanish version is the same as the English except the value is missing so it says:

Da:
Aumento del tamaño máximo de una ciudad
reducción del efecto de la masificación

OK, this I am able to fix, and post the corrected files for each language if you would like. Could I get a French GL from someone? Are there any Italians or Japanese around?