PROJECT: Altered source files

[Martin Gühmann]

Originally posted by Flinx
Going through the 2004.04.30 .RAR, the great library is not included for French, Italian or Japanese; the German version is ok as it includes both overcrowding and maxpop; the Spanish version is the same as the English except the value is missing so it says:

Well obviously I wasn't so careful for the English version then for the German version, but nevertheless we should remove the line with the zero value in the German version as well.

Originally posted by Flinx
OK, this I am able to fix, and post the corrected files for each language if you would like. Could I get a French GL from someone? Are there any Italians or Japanese around?

For the French version your could ask Tamerlin, and maybe also for the rest of the French files, I know he already offered them, for the other languages I don't know, espeacilly for the Japanese version it's a pain.

-Martin

[Tamerlin]

Here is the modified French Great Library (with the correct text for the Hospital) .

Though it did not hold the same mistake the text was incomplete.

The new text is:

[IMPROVE_HOSPITAL_STATISTICS]
Résultat :
Réduit l'effet de surpopulation de {BuildingDB(Building[0]).RaiseMaxPopulation}
Accroît la taille maximale des villes

[Tamerlin]

Sorry Flinx I should have read your post better, the French version of the Great Library I have just sent is wrong as I have copied and pasted the text from the post displaying the original (and wrong) text for Martin's use.

[NEW AND CORRECT TEXT]

[IMPROVE_HOSPITAL_STATISTICS]
Résultat :
Réduit l'effet de la <L: DATABASE_CONCEPTS,CONCEPT_OVERCROWDING>surpopulation<e> de {BuildingDB(Building[0]).RaiseOvercrowdingLevel}
Accroît la taille maximale des villes

[/NEW AND CORRECT TEXT]


[EDIT]Didn't remember I had to use the code and not the character itself for the code to be displayed properly.
Now I understand why there is a space between the ":" and the "D" in all your posts. [/EDIT]

[Martin Gühmann]

2004.05.22
..\ctp2_code\gs\gameobj\CityEvent.cpp
..\ctp2_data\default\gamedata\script.slc
..\ctp2_data\XXXXXX\gamedata\info_str.txt

Where XXXXXX is english, german and french, the needed strings for the English and German version are added to the according info_str.txt, there are also strings added to the French version of the info_str.txt unfortunatly in English in the lack of a French translation. The Italian, Japanese and Spanish version of the info_str.txt are missing. And therefore even English text for these versions of CTP2 are missing.

CTP1 reimplementation by Martin Gühmann: During conquest there is now a chanche of 0.5 accoriding to our const.txt that the attacker takes an advance, given the victim has any advances that the attacker does not have. Both the attacker and the victim get a message about the stolen advance.


2004.05.23
..\ctp2_code\gs\dbgen\RecordDescription.cpp
..\ctp2_code\gs\newdb\*Record.cpp
..\ctp2_code\gs\newdb\*Record.h
..\ctp2_code\gs\newdb\*Record.stamp

The * stands as usual for very combination of letters, meaning every in that directory with Record in its name is included so that no one has to build a debug version before the release version.

The pupose of this is to stop .NET to complain about the fact that all these Init functions in these files don't have a reurn type, the return type void was added to that function. Odd that dbgen did not generated all of the new Record files, well some hand editing solved that problem.

-Martin

[Fromafar]

Bug fixes:

gs\gameobj\PlayerEvent.cpp
Corrected the index of the 'cause' argument in the GrantAdvanceEvent handler.

gs\slic\SlicFunc.cpp
Added input checks and an optional 'cause' argument to the GrantAdvance SLIC handler.
Added reading of the 'army' argument of the ArmyIsValid SLIC handler, instead of returning 0 always - even when the army would have been valid.

gs\slic\SlicStack.cpp
Prevented crashes that may occur when SLIC argument values are invalid.


Notes for SLIC writers:

The crashes could occur with seemingly harmless constructs like:

if (IsValid(x) && AssumeValidUsage(x))

When using C/C++, the AssumeValidUsage(x) part would not have been evaluated when the IsValid(x) part is false, but with SLIC, the AssumeValidUsage(x) part is evaluated regardless of the IsValid(x) result.

With the new SlickStack.cpp code, invalid usage should not cause a CtD anymore. There is a catch, however: invalid expressions may now return 0. When guarded as in the code example above, this is not a problem - after full evaluation, the expression in the if will become false. When unguarded, as in a

if (AssumeValidUsage(x) == 0)

naive test to find out whether the Barbarian player is involved, the result may not be what you expect.

[Edit: link removed. Included in the 2004.06.05 source collection.]

[Fromafar]

Support for the added built-in Slic data members as accessors.

gs\slic\SlicBuiltIn.cpp
AddMember changed to AddAccessor for g.last_player, g.max_player, g.num_of_players, and player[].government. This file is part of the 2004.05.19 playtest release, and has not been changed.

gs\slic\SlicStruct.h
gs\slic\SlicStruct.cpp
Implementation of accessor functionality. These files have been modified to correct problems with the player[].government access as reported by BureauBert.

[Edit: link removed. Included in the 2004.06.05 source collection.]

[Fromafar]

Activision patch reimplementation: keep the embargo and declare war buttons enabled when the user cancels the action.

ui\interface\diplomacywindow.cpp
ui\interface\intelligencewindow.cpp

[Edit: link removed. Included in the 2004.06.05 source collection.]

[Fromafar]

Bug fix: corrected the ArmyIsValid function once more.

gs\slic\SlicFunc.cpp

[Edit: link removed. Included in the 2004.06.05 source collection.]

[Locutus]

The very latest version of the credits file.

[maddogmpe01]

mss.h, Mss32.dll

I can not get these files, from

Top of post one links for:
..\ctp2_code\sound\mss.h
..\ctp2_code\libs\miles\mss.lib

pointing to -> http://users.tpgi.com.au/jonwil/mss32.lib,

http://users.tpgi.com.au/jonwil/mss.h

These are no longer valid.

They are not around. could some one post these in an accessable area, so I can get a clean first compile.

[Flinx]

The same question in three threads!? One right below a post with the answer!?!

In the PROJECT: Altered source files thread people post altered files to be included in the next playtest version of the game. Peridocally a zip of all the updated files is posted. You can find the files you are looking for in one of these.
2004.01.31 can be found at the bottom of the first post.
2004.03.28
2004.04.18 was the last time this all-inclusive zip was made. you will need to download the changes one-by-one from that point on

[maddogmpe01]

Brain Fart

Opps, dat was a stinker weren't it.

Yep Can't read, but can still code, magic it is.

[Fromafar]

Bug fixes

gfx\spritesys\BattleViewActor.cpp
gfx\spritesys\TradeActor.cpp
gfx\spritesys\UnitActor.cpp
Prevented some possible crashes. Not sure that these are really useful. I got one of these - after clicking away a GC000.spr not found in asset tree message - when loading a CTC save file with the original game setup selected in the ModManager.

gs\gameobj\CityEvent.cpp
Prevented a possible crash. Untested, but might solve the Solaris project bug.

ui\interface\wondermoviewindow.cpp
Repaired a memory leak with the wonder movie pop-up window.

[Edit: link removed. Included in the 2004.06.05 source collection.]

[Lui2]

Calculating score

Code fix

I changed the used values in the game score calculation to the proper (as I mean) limits to value the owned cities and there sizes .

Changed:
300.000 to 30.000
1.000.000 to 100.000
5.000.000 to 500.000

Changed also the text in the text files to the newly setted limits.

2004.06.04
..\ctp2_code\gs\gameobj\Score.cpp
..\ctp2_data\XXXXXX\gamedata\exp_str.txt

Where XXXXXX is english, german, spanish, italian and french. The Japanese version of the exp_str.txt i had not changed but needs a change probably also.

[Martin Gühmann]

Originally posted by Lui2
I changed the used values in the game score calculation to the proper (as I mean) limits to value the owned cities and there sizes .

Well the limits you think, are these really the proper limits? I guess every modmaker has his own ideas about proper limits, therefore it would be better to expose these limits to DiffDB.txt, yes for each level of difficuilty a set of limits. However until someone implements this in a more modder friendly way Your solution is ok.

2004.06.05
..\ctp2_code\ui\aui_common\tech_wllist.h

Fix by Martin Gühmann to make sure that tech_wllist.h copiles on copilers which do not support implecit typenames.

-Martin