CTP2 apolyton v 2009-06-01 crashes when a civ is conquered

[EPW]

With the release build, I was able to reproduce the error.
I added these lines to AddOwnersGoalsForCities:

if(g_player[ownerId])
        return;

And these lines to AddForiegnersGoelsForCities:

if(g_player[foreignerId])
        return;

Is this right Martin? I thought it should have been:

if(!g_player[foreignerId])
        return;

Anyways, it did get rid of the crash mrgarofalo posted.

Sadly, I'm now getting the crash I posted in the previous post with the release build.

[Martin Gühmann]

With the release build, I was able to reproduce the error.
I added these lines to AddOwnersGoalsForCities:

if(g_player[ownerId])
        return;

And these lines to AddForiegnersGoelsForCities:

if(g_player[foreignerId])
        return;

Is this right Martin? I thought it should have been:

if(!g_player[foreignerId])
        return;

Yes it should be the last one, well actually I prefer this one:

if(g_player[foreignerId] == NULL)
        return;

Since this makes it clear that it is a pointer and not a boolean value.

Sadly, I'm now getting the crash I posted in the previous post with the release build.

Maybe it helps to recompile the source code, otherwise you have to work with the debug version and the debugger.

-Martin

[EPW]

Yes it should be the last one, well actually I prefer this one:

if(g_player[foreignerId] == NULL)
        return;

Since this makes it clear that it is a pointer and not a boolean value.



Maybe it helps to recompile the source code, otherwise you have to work with the debug version and the debugger.

-Martin

I did the fix properly this time with a clean build and the crash is gone!

[mrgarofalo]

Hey EPW... I made the two entry changes that you and Martin suggested to the ctpai.cpp,, could you walk me through how to compile it?

[EPW]

If you send me your email I can just send you the compiled files. Compiling is a rather arduous task, you can look here to get an idea: http://apolyton.net/forums/showthread.php?t=183987

[EPW]

I just sent it to you, please let us know if it works.

[SDKane]

I am experiencing this problem.

I wiped out my Ctp2 from my computer and did a clean install.
Installed the Apolyton v 2009-06-01 edition
Installed the 27 Civ map.

I started playing as the english and got up to 3 cities before the game crashed - after further reading of these forums I tested a different method and played (cheated) and placed a unit beside another empires city and took it over - the game crashed.

If someone could direct me to a fix of this problem I would be grateful. All in all, when another civ isn't conquered the game is fine

[Maquiladora]

I just sent it to you, please let us know if it works.

Maybe this fix can be released as a patch now we know that it works.

[EPW]

Maybe this fix can be released as a patch now we know that it works.

He got some kind of incompatibility error when he tried to use it. No idea why.

[SDKane]

So there is no sure fix to date on this problem?

PS: hi everyone, I really forgot to say hi in my first post, i've been downloading and stuff from this site for a while (1y+ maybe) just now I finally have a reason to post. You guys really have something going with this apolyton edition!

[EPW]

Yes, there is a fix, but it hasn't been released yet.

[Maquiladora]

PS: hi everyone, I really forgot to say hi in my first post, i've been downloading and stuff from this site for a while (1y+ maybe) just now I finally have a reason to post. You guys really have something going with this apolyton edition! [/I]

Hi

Yes, there is a fix, but it hasn't been released yet.

Can we release a patch then?

Or do we need Martin to release it compiled with VC++6? I'm still not clear on this.

[EPW]

Hi

Or do we need Martin to release it compiled with VC++6? I'm still not clear on this.

I don't know why it didn't work, but I suspect this is the case.

[Maquiladora]

I don't know why it didn't work, but I suspect this is the case.

Did you send him just the new exe to test or the exe and map file?

[EPW]

I sent him the exe and what I thought to be the map file.