CTP2 apolyton v 2009-06-01 crashes when a civ is conquered

[mrgarofalo]

Hi evreyone, the game crashes on me after I conqueror a civ(in this case Greece) here's the crash.txt

Version 2009-06-02
0x007d8010 [?Add_New_Goal@Scheduler@@QAEXABQAVGoal@@@Z + 0x20]
0x007f6f15 [?AddForeignerGoalsForCity@CtpAi@@SAXABVUnit@@H@Z + 0x115]
0x007f6c6a [?GEVHookCallback@CtpAi_CreateCityEvent@@EAE?AW4GAM E_EVENT_HOOK_DISPOSITION@@W4GAME_EVENT@@PAVGameEve ntArgList@@@Z + 0x7a]
0x0057f357 [?Activate@GameEventHook@@QBE?AW4GAME_EVENT_ERR@@PA VGameEventArgList@@HAAH@Z + 0x37]
0x0057fd58 [?ActivateHook@GameEventManager@@QAE?AW4GAME_EVENT_ ERR@@W4GAME_EVENT@@PAVGameEventArgList@@HAAH@Z + 0x28]
0x0057de3d [?Process@GameEvent@@QAE?AW4GAME_EVENT_ERR@@XZ + 0x2d]
0x0040c301 [?Process@CivApp@@QAEHXZ + 0x201]
0x00406f14 [?CivMain@@YGHPAUHINSTANCE__@@0PADH@Z + 0x394]
0x00406975 [WinMain@16 + 0x65]
0x0080685c [WinMainCRTStartup + 0x134]
0x7c816fe7 [__onexitbegin + 0x7be499cf]

Thanks in advance for the help!

[EPW]

Do you have the latest version(Rev 990 released on the 1st of June)? It was supposed to fix this problem.

http://apolyton.net/forums/showthread.php?t=185707

Nevermind, I see that you do have the latest version. Hopefully someone else will be able to figure out the problem.

[mrgarofalo]

Thanks for the quick response! I hope someone can figure it out, the game is GREAT other than the crashing

[Martin Gühmann]

Well since I don't have access to my computer for a while someone else has to do the fix.

To fix it open the file ctpai.cpp find the functions AddForeignerGoalsForCity and AddOwnerGoalsForCity and check the PLAYER_INDEX argument, whether it represents a valid player.

For the AddOwnerGoalsForCity you have to add the following lines:

if(g_player[ownerId])
     return;

Compile it and upload a new exe and a new map file.

-Martin

[mrgarofalo]

Martin, I could not find ctpai.cpp in the CTP2 directory, is it possible it wasnt installed correctly?
^
|
|
Nevermind this,, i didnt install the source code. I just installed it and found ctpai.cpp

[mrgarofalo]

I added the line under AddOwnerGoalsForCity, tried to play the save file again but it crashed.... dont know if it's any different this time but heres the new crash txt

Version 2009-06-02
0x007d8010 [?Add_New_Goal@Scheduler@@QAEXABQAVGoal@@@Z + 0x20]
0x007f6f15 [?AddForeignerGoalsForCity@CtpAi@@SAXABVUnit@@H@Z + 0x115]
0x007f6c6a [?GEVHookCallback@CtpAi_CreateCityEvent@@EAE?AW4GAM E_EVENT_HOOK_DISPOSITION@@W4GAME_EVENT@@PAVGameEve ntArgList@@@Z + 0x7a]
0x0057f357 [?Activate@GameEventHook@@QBE?AW4GAME_EVENT_ERR@@PA VGameEventArgList@@HAAH@Z + 0x37]
0x0057fd58 [?ActivateHook@GameEventManager@@QAE?AW4GAME_EVENT_ ERR@@W4GAME_EVENT@@PAVGameEventArgList@@HAAH@Z + 0x28]
0x0057de3d [?Process@GameEvent@@QAE?AW4GAME_EVENT_ERR@@XZ + 0x2d]
0x0040c301 [?Process@CivApp@@QAEHXZ + 0x201]
0x00406f14 [?CivMain@@YGHPAUHINSTANCE__@@0PADH@Z + 0x394]
0x00406975 [WinMain@16 + 0x65]
0x0080685c [WinMainCRTStartup + 0x134]
0x7c816fe7 [__onexitbegin + 0x7be499cf]

[EPW]

You have to compile the code. I'll post the fix tonight (5-7 hours) if no one else does.

[mrgarofalo]

Thanks EPW!!

[Protra3211]

Thats odd.I have the latest playtest 990 and have conquered a civilization. I have had no such crash or any problems so far.
Played over 250 turns.Great game and will give more detail on how the AI is doing by the 400th turn.

[EPW]

Thanks EPW!!

Can you post the save game in question so I can test it?

[EPW]

I can't upload the files due to the file size limit...

[mrgarofalo]

Ok, here's the file

[Martin Gühmann]

I can't upload the files due to the file size limit...

There should be some free upload sites out there. How much space do you need by the way?

-Martin

[EPW]

I can reproduce your crash, but it produces a different crash.txt when I use the "Final with logging" build! I find that rather odd... I'll try it with the fix now.

Version 2009-06-12
  0x006c72c1  [?DisbandObsoleteUnits@Agent@@QAEHXZ + 0x291]
  0x0ad4aff8  [__onexitbegin + 0xa4aadd0]
  0xfa0a1f01  [(kernel) + 0x0]

[mrgarofalo]

Ok, thanks again for helping!