Announcement

**Ekmek** · March 29, 2007, 23:46

i have confirmed this crash in separategames numerous times. any idea where it came from?

**Ekmek** · March 30, 2007, 00:30

ok trying to rever the problem i went through ctp2ai and unitdata and there was no issues but armydata may be the problem because iget these compile errors and they are related to water

Code:

...ctp2_code\gs\gameobj\ArmyData.cpp(843) : error C2556: 'short __thiscall ArmyData::CountMovementTypeSea(void) const' : overloaded function differs only by return type from 'unsigned int 
__thiscall ArmyData::CountMovementTypeSea(void) const'
        ...ctp2_code\gs\gameobj\ArmyData.h(161) : see declaration of 'CountMovementTypeSea'
...ctp2_code\gs\gameobj\ArmyData.cpp(843) : error C2371: 'CountMovementTypeSea' : redefinition; different basic types
        ...ctp2_code\gs\gameobj\ArmyData.h(161) : see declaration of 'CountMovementTypeSea'
...ctp2_code\gs\gameobj\ArmyData.cpp(1705) : error C2264: 'CountMovementTypeSea' : error in function definition or declaration; function not called
...ctp2_code\gs\gameobj\ArmyData.cpp(7088) : error C2248: 'm_array' : cannot access protected member declared in class 'CellUnitList'
        ..\gs\world\cellunitlist.h(197) : see declaration of 'm_array'

**Martin Gühmann** · March 30, 2007, 16:02

Re: [DEBUG] Maq's CanThisCargoUnloadAt crash

Originally posted by E
I tried a debug version and the first, before start up I got:

Code:

Assertion failed: setnewh.cpp line 52  new_p == 0

I get this two, you shouldn't find this file on your computer and the assert isn't recorded in the log files.

-Martin

**Fromafar** · March 30, 2007, 16:51

It looks like my standardisation attempts are not appreciated by MSVC6.

Regarding the CanThisCargoUnloadAt crash: the original code had something like

Code:

sint32 Num() const { if  (!this) return 0 else return m_nElements; }

in CellUnitList.h. This is not good: executing a method call on a NULL pointer is undefined behaviour (meaning the compiler can do anything it wants) according to the standard. MS has apparently decided to not crash until you actually try to access members or derefence the pointer in some other way, but expecting NULL->Num() to be 0 is not portable. Changing it to

Code:

sint32 Num() const { return m_nElements; }

uncovers some invalid calls, such as the dest_army->Num() in UnitData::CanThisCargoUnloadAt (where the_dest_army may be NULL), but that is just a matter of further code improvement.

The other issue looks like the set_new_handler is causing problems. I introduced it to make a failing new throw a std::bad_alloc exception (MSVC has it returning NULL by default). If it doesn't work for MSVC6, feel free to remove it.

And E, it is unwise to revert only part of my changes. Reverting ArmyData.cpp (containing a modified method signature) without reverting the declaration in ArmyData.h

. No compiler is going to like that.

For the "loading save game" crash, you may have to check the revision that was used to save the game. I did restore the format in revision 710, so there may be a problem when you try to load a game that was saved before revision 710.

**Ekmek** · March 30, 2007, 23:11

the change compiled and i tested it on maq's save game and it worked. so i think this action is closed.

Announcement

[DEBUG] Maq's CanThisCargoUnloadAt crash

[DEBUG] Maq's CanThisCargoUnloadAt crash

Comment

Comment

Comment

Comment

Comment