GENERAL: For Laughs

[ahenobarb]

Found these while looking through the code and just had to share:

Happy.cpp

void Happy::SetFullHappinessTurns(sint32 turns)
{
	m_fullHappinessTurns = turns;
	m_happiness = 100;
	m_tracker->ClearEntries(HAPPY_REASON_SMOKING_CRACK,
							HAPPY_REASON_MAX);
}

in armydata.cpp

BOOL g_smokingCrack = TRUE;

[centrifuge]

[NelsonAndBronte]

In fscompete.cpp

attack_the_bastard = new GoalAttack(ai, him, pos);

[Keygen]

This looks like Winnie's variable naming style

[The Big Mc]

what do activision pay there programmes

on second thought probably peanuts

[The Big Mc]

Why the hell did this post three times

[The Big Mc]

:dp

[Asmodean]

Yeah...this has st_swithin written all over it

Asmodean

[child of Thor]

Originally posted by The Big Mc
what do activision pay there programmes

on second thought probably peanuts

Obviously too much if they can afford to smoke crack?
Drugs are Bad - especially beer

But good to see the team were keeping their spirits up in those dark times - i'm sure a few more gems will be unearthed for our asmusement

[The Big Mc]

Originally posted by child of Thor


Drugs are Bad - especially beer

beer is good beeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeee eeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeeer

emmm beeeeeeeeeeeeeeeeer

[uppi]

in ui/interface/helptile.h

#ifndef  THIS_IS_MY_CONSTANT_SO_YOU_BETTER_NOT_USE_IT
#define  THIS_IS_MY_CONSTANT_SO_YOU_BETTER_NOT_USE_IT

I guess they had _some_ problems with the naming of their constants...

[The Big Mc]

	if(!city.GetData()->GetCityData()->CapturedThisTurn()) {
		if(g_network.IsClient()) {
			g_network.RequestResync(RESYNC_PROBABLE_CHEATER);
		}
		return SFN_ERROR_OK;
	}

Charming

[Martin Gühmann]

Originally posted by The Big Mc

	if(!city.GetData()->GetCityData()->CapturedThisTurn()) {
		if(g_network.IsClient()) {
			g_network.RequestResync(RESYNC_PROBABLE_CHEATER);
		}
		return SFN_ERROR_OK;
	}

Charming

From where did you get it, Big MC? Looks like here is the reason why my City Capture options doesn't work in MP.

-Martin

[Peter Triggs]

Martin,

It's in slicfunc.cpp:

SFN_ERROR Slic_DoFreeSlaves::Call(SlicArgList *args)
{
    if (args->m_numArgs > 0)
        return SFN_ERROR_NUM_ARGS;

	Unit city = g_slicEngine->GetContext()->GetCity(0);

	if(!g_theUnitPool->IsValid(city)) {
		return SFN_ERROR_OK;
	}

	if(!city.GetData()->GetCityData()->CapturedThisTurn()) {
		if(g_network.IsClient()) {
			g_network.RequestResync(RESYNC_PROBABLE_CHEATER);
		}
		return SFN_ERROR_OK;
	}

	if(g_network.IsClient()) {
		g_network.SendAction(new NetAction(NET_ACTION_FREE_SLAVES, city.m_id));
	}

    city.FreeSlaves();

    return SFN_ERROR_OK;
}

I noticed it yesterday and was going to suggest that either you or JohnBTW might want to modify it so that slaves could be freed not just on the turn that the city is captured. I couldn't find any other occurence of 'RESYNC_PROBABLE_CHEATER' in a .cpp file, but it sounds like it was intended to be some kind of defense against multiplayer cheating.

[Martin Gühmann]

Yes it is the only occurence in a *.cpp file, for changing it I would like to keep the current function, when there are zero arguments. If there is one argument and it is a city the slaves should be freed.

And Peter why don't you play with the slic functions on your own then you might find out some usefull stuff. To alter this slic function you can basicly find everything you need in that file, just check the other functions.

-Martin