DEBUG: The neutral tile improvement pillage bug

[Martin Gühmann]

Originally posted by J Bytheway
Will this cause any problems if a player has gaia controller tile imps which enter or leave his borders after being constructed?

Difficuilt question we need to check where the HandleTerrImprovementChange is used and then we can tell.

Gilgamensch changing the owner is I feel something that shouldn't be done the belongs noone thefore the tile improvement shouldn't belong to anybody either, well this I think another bug.

-Martin

[Gilgamensch]

OK, then I see two ways:

If you don't like to change it to babarian (which IIRC is player 0)

then

we would need to remove all TI's if the border changes......


But, I don't see where your problem would be, to change it to babarian? (espacially for pillaging?)

[Martin Gühmann]

Well I tried to move the bugfix into the Player::GetGaiaController but as I disabled all the code I added here, nothing happened no crash.
I just added the fix for the buildingutil.cpp by NelsonAndBronte. So I have no idea why it doesn't crash now.

-Martin

[Gilgamensch]

sounds a little bit like a reversed Murphy's Law.............

But if it doesn't chrash anymore, would be good (just had one of those games.............)