Dale/Snoopy PatchMod (Bug-fixes and more)

[snoopy369]

Originally posted by Caledorn
This patchmod makes my Colonization game crash to desktop the instant one of my competitor European colony nations founds a city ... At least I think this is what causing it - enabling logging and debugging gives this output in PythonDbg.log as the last logentry :

PY:City Built Event: Isabella

I'm afraid the colonization.exe.dmp file didn't offer much help to me, as I'm not fluent in reading dumpfiles in hexadecimals :-P

Hmmm, interesting ... i'll have to look at what exactly changed that could cause that.

[snoopy369]

Yep, crashes on me too. I'll have to talk to Dale about it, since I'm not sure what of his changes is likely to have caused it (but it doesn't crash when I run the version I compiled prior to Dale making the latest set of changes) so either his compiler doesn't like something I did, or more likely it was a more recent change... we'll hunt it down either way
Caledorn. Thanks!

[DarthVeda]

Nice job on doing something about the sailing distance

[Dale]

Okay I know the fix for spawning in odd locations (such as in the middle of the continent). Sorry, my fault.

Looking into the found crash now.

[Dale]

Okay I've worked out the founding crash too. Will post an update now.

[Dale]

v1.02 posted in OP

[Flash]

Hey Guys,

I really appreciate the work you are doing, but could I have the option of not randomly placing the Indian civs? Mainly for the purpose of Western Hemisphere Earth maps?

[Dale]

Check the fix list, we haven't fixed static start locs yet.

[The Rusty Gamer]

Is it possible to limit the number of wagons to the number of colonies you have, as in col 1?

[xflashx]

remove this message from thread if you want,

but please answer, did you guys change the fisherman and farmer specializations?

They used to be +100%, now they are like +3 food.... I can't figure out what changed this, as even civpedia says that now.. but i could have sworn it was 100% before...

I see nothing in patch notes regarding

Thanks for answer!!

[Dale]

Fisherman/farmer has always been that.

[Dale]

I'm pretty sure I've found why the AI doesn't camp defenders in it's cities. The following call to AI_IsWarPossible() in CvCity::AI_NeededDefenders() (or "how many defenders do I need in my cities") always returned false, and thus returned zero as the number of needed defenders.

I also changed from +1 for every 8 pop, to 4 pop. Testing it now to see the effect.

int CvCityAI::AI_neededDefenders() const
{
	PROFILE_FUNC();
	int iDefenders = 0;
	AreaAITypes eAreaAI = area()->getAreaAIType(getTeam());
	
	if (isNative())
	{
		int iNeeded = 2 + (getPopulation() + 1) / 2;
		
		if (eAreaAI == AREAAI_OFFENSIVE)
		{
			iNeeded--;
		}
		else if (eAreaAI == AREAAI_DEFENSIVE)
		{
			iNeeded++;
		}
		return iNeeded;
	}
	
	if (GET_PLAYER(getOwnerINLINE()).AI_isKing())
	{
		return 2 + getHighestPopulation() / 2;
	}

//	if (!(GET_TEAM(getTeam()).AI_isWarPossible()))
//	{
//		return 0;
//	}
		
	iDefenders = 1;
	
	if (GET_PLAYER(getOwnerINLINE()).AI_isStrategy(STRATEGY_REVOLUTION_PREPARING))
	{
		if (plot()->getNearestEurope() != NO_EUROPE)
		{
			iDefenders += 2;
			if (GET_PLAYER(getOwnerINLINE()).AI_isStrategy(STRATEGY_REVOLUTION_DECLARING))
			{
				iDefenders += 3;
			}
		}
	}
		
	
	iDefenders += getPopulation() / 4;
//	iDefenders += getPopulation() / 8;
	
	return iDefenders;
}

[Dale]

Scrap that idea.

[snoopy369]

Which part of it?

[Justas]

A quick request, please increase the amount of AI opponents in map sizes... Currently its ridiculous, you get maps that are half empty. You could easily fit atleast 3 AIs on a small map.