Initial Python reference

[GIR]

IT WORKS!!!!!!!!!!!!!!!!!!
wow, I L O V E YOU Bhruic
THX a lot

[GIR]

my ?last? question in this thread...

what is wrong with the last line of this code (unit don't spawn)?

def onBuildingBuilt(self, argsList):
        'Building Completed'
        pCity, iBuildingType = argsList
        game = CyGame()


        if iBuildingType == gc.getInfoTypeForString( 'BUILDING_xyz' ):
            pPlayer = gc.getPlayer(pCity.plot().getOwner())
            gc.getTeam(pPlayer.getTeam()).setHasTech(gc.getInfoTypeForString( 'TECH_zyz' ), true, pPlayer.getID(), false, false)
            #gc.getPlayer(pCity.plot().getOwner()).initUnit( 17, pCity.getX(), pCity.getY(), UnitAITypes.NO_UNITAI )
            pPlayer.initUnit( 17, pCity.getX(), pCity.getY(), UnitAITypes.NO_UNITAI )
... 

[Bhruic]

Try:

pPlayer.initUnit(gc.getInfoTypeForString('UNIT_WARRIOR'), pCity.getX(), pCity.getY(), gc.getInfoTypeForString('NO_UNITAI')) 

Bh

[GIR]

thx for your help!
it was my fault that the last line in the code didnt worke because i created a backup folder in the python folder instead of renaming it (...mod...\assets\Python\backup\cveventmanager.py) and cIV used that backupfile (dont know why - maybe im just too stupid).
now it works and im happy

[Impaler[WrG]]

I'm wondering is it possible to add new elements to the various XML files AND get python to read this data? Would this require the SDK to write new API functions for extraction the data?

The specific goal I have is to convert Civics for the C4:AC mod
I would create a new Civic for each level of the social effect meters SMAC uses for example "<"POLICE_PLUS_TWO">" would handle the effects of a +2 police rating and be under a "<"POLICE">" CivicType. The effect could be anything that a normal Civic can do.

All of these new Civics would be hidden from direct usage by the player and they would instead select from a subset of the Civics which are defined with a boolean to be the "real" Civic options like FreeMarket and Cybornetic. They would be featureless like Barbarism and Paganism but need to have modifiers like "<"Police_Meter">"-1"<"/Police_Meter">" that will be totaled up by Python to get to net meter values and set the meters in the backgroud.

I cant realy see any other way to create SMAC style Social Enginering in Civ4. Is it possible to do such a thing (oh and by the way I know I will need to alter the Schem'a but that not a problem, its the Python calls I need to be able to perform).

[PJayTycy]

Changes in patch 1.09 (from the file CvEventManager.py) :
Red is old version, black is new version.

onCombatCalc => onCombatLogCalc
onCombatHit => onCombatLogHit



actually, I'm not sure if it's a change since 1.09 or if it's been like that all the time.

[Ganraeln]

What I really want to mod for Civ4 is the worker behavior. I have been combing the python reference, but can't seem to find anything related to the worker automation.

Is this behavior moddable? If so, where do I need to look?

[The_Aussie_Lurker]

Hi Locutus. I am a total newb when it comes to Python, but I was wondering if you could give me a few pointers? There are a few things I am trying to achieve, and I was wondering how I might go about it.

(a) I want the computer to check-each turn-for civics settings and if CivicSetting=Slavery, then [plus two slaves].

(b) I want the computer to check each city-every turn-for specialists and, if SpecialistSetting=Soldier, then reduce unit build time by 10% and/or then add +2XP.

(c) As with (a), I want the computer to check each turn for civics settings and, if CivicSetting=X then add Building Y to the build queue.

(d) I want to do a python script which might allow a specialist or building, if present, to strip away the number of Unhappiness points a city has.

(e) Lastly I want to write a script which looks at Health-Unhealth and, if >0, then +5% city growth per turn or, if <0, then -5% city growth per turn. I would like to do the same thing with happiness, but with it being applied to production and commerce.

Anyway, sorry to be such a pain, but any pointers you can give-such as what part of the code I should tackle-would be VERY much appreciated.

Yours,
Aussie_Lurker.

[GIR]

hi @ all
new problem... (getBonusType)
what is wrong with the last three lines? (CvEventManager.py file)
example:

    def onImprovementBuilt(self, argsList):
        'Improvement Built'
        iImprovement, iX, iY = argsList

        pPlot = CyMap().plot(iX,iY)
        if(iImprovement==gc.getInfoTypeForString('IMPROVEMENT_MINE')):
            if(pPlot.getTerrainType()==gc.getInfoTypeForString( 'TERRAIN_GRASS' )):
                pPlot.setImprovementType(-1)
        if(iImprovement==gc.getInfoTypeForString('IMPROVEMENT_LUMBERMILL')):
            if(pPlot.getFeatureType()==gc.getInfoTypeForString( 'FEATURE_FOREST' )):
                pPlot.setImprovementType(-1)
        if(iImprovement==gc.getInfoTypeForString('IMPROVEMENT_FARM')):
            if(pPlot.getBonusType()==gc.getInfoTypeForString( 'BONUS_HORSE' )):
                pPlot.setImprovementType(-1)
.
.
. 

the code works with the mine and the lumbermill improvement, but not with the farm improvement, because the if(pPlot.getBonusType()==gc.getInfoTypeForString( 'BONUS_HORSE' )): string dont work. it has the same syntax than the strings above but what the hack...

[The_Aussie_Lurker]

Apologies for sounding like a complete moron, GIR, but what exactly does this script do? Then I might be able to look at it with 'fresh eyes' as it were.

Also, there is something else that I want to write a script for. Have the computer look for a strategic resource a civ has access to and if resource X=yes, then Technology Y=beakers/2

So, for example, if Resource (Iron)=yes, then Iron Working=Beakers (X/2).
Hope that makes sense.

Yours,
Aussie_Lurker.

[Bhruic]

Originally posted by GIR
the code works with the mine and the lumbermill improvement, but not with the farm improvement, because the if(pPlot.getBonusType()==gc.getInfoTypeForString( 'BONUS_HORSE' )): string dont work. it has the same syntax than the strings above but what the hack...

It does have the same syntax, but it shouldn't.

BonusType getBonusType(TeamType eTeam)

That's the function - you'll note that it takes a variable, the eTeam. You can't use it with (), because that's not how it works.

Bh

[GIR]

@The_Aussie_Lurker:

the code is only a stupid example (dont makes any sense). if you build a farm and this farm is on a horse bonus title, the farm should be deleted (pPlot.setImprovementType(-1 )). i was of the opinion that the getBonusType command work like the getFeatureType and the getTerrainType command, but it's different (but the setBonusType command work, how strange!!).

@Bhruic:

thx!
where is the source of all your knowledge - is there some kind of guid anywhere? i used the PyHelpers.py file but it doesnt help much especially for the getBonusType command.
and now im totally lost (eTeam ). how should the string looks like?

[Bhruic]

You'll want to check out http://civilization4.net/files/modding/PythonAPI/

It lists the various classes and functions that you can use. The reason that Bonus type is tied to teams is because the whole team will get to use that bonus, if they are connected to it. Ie, if a city is connect via roads to a Horses bonus, then the city gets to use it. Improvements don't work like that, so there's no need to check.

Bh

[GIR]

wow! thx
thats a great guid!
now it works!

[Ganraeln]

Ok guys, obviously my last post was too vague.

I am a software engineer by trade, so I'm no idiot. What I'm looking for, and have been unable to find, is enough information in the python reference to determine how to automate a worker. I'm guessing there just isn't enough exposed in the python interface to do it, or there isn't enough documented to figure it out. Am I wrong?

What I do see, that gives me some sort of hope, is definitions for AUTOMATE types. I'd think that perhaps checking the unit type, along with whether the unit is set to AUTOMATE_BUILD, is a starting point.

Where I'm falling down is determining what type of enhancement the worker intends to put on a given plot, and how many turns into the enhancement the worker is. The intent would be to change the enhancement type if the worker is on the first turn of work.

Another problem is that I've noticed that the automated workers ignore mining hills entirely, so I'm not sure if the above approach covers all bases. I would prefer to add to the list of viable worker automation terrain types, and dictate what enhancements will be built.

Or am I clutching at straws here? Any thoughts? Bueller?

[PJayTycy]

Ganraeln : I think your question is too complex to be answered in this topped thread where all subjects flow through each other. You might get better results with a new thread with the only focus on your problem.

[Ganraeln]

PJay,

Thanks for the response. After posting the first time, and seeing a bunch of posts responding to something else entirely, I was probably coming off a bit snippish. That, I'm sure, will get me nowhere, especially since we should all be grateful for any information given out by these fine folks.

I'll just wait for the SDK, I think. I'm hoping the documentation is much better then. Otherwise, it's looking very much like hunt and peck - something I've never found very much fun.

[The_Aussie_Lurker]

Hi guys,

Just let me quickly explain what I am trying to attempt.

I have created a specialist-Slave-which is only ever going to appear under the Slavery Civic, because I think the Slavery Civic is currently a little lacklustre.

Anyway, After modding the SpecialistInfo.xml file, I did a VERY simple python script, called CvCivics.py, to access this specialist under the Slavery Civic. Problem is, it is NOT currently working. Here it is:

def onBeginPlayerTurn(self, argsList):
'Civic Chosen'

iGameTurn, iPlayer, iCity = argsList

if iCivic==gc.getInfoTypeForString('CIVIC_SLAVERY')):
pSpecialist.gc.getFreeSpecialist(7)-int(2)

print("You have enslaved the local natives")

Can anyone help me with some advice as to what I need to add? Thanks in advance.

Yours,
Aussie_Lurker.

[PJayTycy]

This part looks very wrong:

pSpecialist.gc.getFreeSpecialist(7)-int(2)


if you defined gc like everybody does, it can't be used with anything in front of it. I don't quite get what you want this line to do exactly.
What do you think pSpecialist is (it's not defined in your code here)?
Why the - int(2) ?


Anyway, the freespecialist functions you find in the API are for things like mercantilism giving 1 free specialist, and can be set in XML without python. Perhaps you'll have to give the specialists' bonusses directly to the cities instead of giving them indirectly through a specialist.

[The_Aussie_Lurker]

Hi there. Thanks for the advice regarding specialists. Actually, things have evolved quite a bit since that post, and I feel quite positive that I have got the right code now. I will post the results of my efforts within the next 7 days.

Yours,
Aussie_Lurker.

[platypotamus]

Is there anyway to define new "types"?

Specifically, I'd like to add a couple of new CivilopediaPageTypes, but I can't find a place to do this.

[The_Aussie_Lurker]

Does anyone know if it is possible to link tech rates to in-game factors via python? For instance I would like to do something like this:

essentially if player has resource=copper, then tech rate for bronze working is 0.75 of normal.

Anyone able to help me with this?

Yours,
Aussie_Lurker.

[LDiCesare]

Anyone knows how rivers are generated in map scripts? I can see land/peak/hills/water on one side, ice/tundra/grass/plains/desert on another, and resources and forest/jungle in the third part, but can't find rivers.

[LDiCesare]

On river generation in map scripts: It is done by a set of global functions, mainly, if I'm not mistaken, getRiverAltitude, which seems to provide the altitude of a plot in order to compute where the river should flow.
The problem is the rivers are computed to flow from a source to the sea rather than the opposite. This means the rivers will sometimes cross mountain ranges because they seem unable to decide to go sideways when they meet a mountain, and even that wouldn't ensure they will someday meet the sea. If anyone knows how to replace the whole river system generation, I'd like to hear from them.

[Yosh]

Hi I've got a question for someone:

I want to extract the combat log; I've found the relevant functions that write to the combat log, but since CyInterface().addCombatMessage is not in the SDK, I can't think of a way to get these logs extracted to a text file!

Any help on this would be appreciated -- I'm probably looking in the wrong places since I went to the Python first (I'm a programmer) :P

[Zuul]

If you have a unit and move it, how to know on what tile it was on? So you can change things on a tile when a unit moves away from it.

[Bhruic]

There's no way to do that. If you read earlier in the thread, you'll note I asked already, and was told I'd have to wait for the SDK - so I guess you will too.

Bh

[Zuul]

Okey :-). Well my solution was to check every tile around the unit that moved. One could also check the direction and reverse it to get the old tile but I didn't want to do that.

Originally posted by Bhruic
Another question - it's possible to add new Promotion types, yes? I haven't been able to successfully do so at this point, just want to make sure I'm not banging my head against the wall pointlessly.

edit: nm, got it working. Apparently if you add a new promotion type and try and load an old savegame, it'll die, but if you start a new one, it works fine.

Bh

How do you add it?

Originally posted by Locutus
General
onUnitCreated
'Unit Completed'
arguments: unit

onUnitLost
'Unit Lost'
arguments: unit

Can't get those to work. When are they called? When I tried to check unit x y it gave me an error.


Also is there any onImprovementRemoved or something?

[siroxo]

Is there an ETA on documentation for the Map generation scripts? If not, has someone figured out the name for floodplains terrain features in the FeatureGenerator class? I haven't found it in any of the map scripts.

[Bhruic]

Originally posted by Zuul

How do you add it?

Just edit the xml file.

Can't get those to work. When are they called? When I tried to check unit x y it gave me an error.

Also is there any onImprovementRemoved or something?

They both work fine for me. What exactly are you trying to do with them?

As for removing Improvements, no, no function exists for that (that I'm aware of).

Bh